Skip to content

fix: Correct class name of HttpTransporterFactory#2393

Merged
ryanjbaxter merged 3 commits intospring-cloud:mainfrom
pieninck:fixTypoInAetherFactories
Feb 5, 2026
Merged

fix: Correct class name of HttpTransporterFactory#2393
ryanjbaxter merged 3 commits intospring-cloud:mainfrom
pieninck:fixTypoInAetherFactories

Conversation

@pieninck
Copy link
Contributor

fixes #2392

fixes spring-cloud#2392

Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
@marcingrzejszczak
Copy link
Contributor

I wonder how to test this. The only thing that comes to my mind is for now a unit test that would literally check if those strings are FQN of classes taken from the classpath. We have the classes on the classpath already, if we extract the strings into constants we could unit test if those constants are equal to FQN of org.eclipse.aether.transport.http.HttpTransporterFactory.class . That way we will ensure that no typos are present. WDYT?

@pieninck
Copy link
Contributor Author

This means that spelling mistakes are at least immediately noticeable. I will extract the strings into constants and add tests to check them against the FQN.

fixes spring-cloud#2392

Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
@pieninck
Copy link
Contributor Author

I tried to implement your suggestion of extracting and testing the fqn. Since it was my first commit to a spring project, please let me know if anything is missing.

fixes spring-cloud#2392

Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
@pieninck
Copy link
Contributor Author

Is there anything else I need to do, or is everything okay so far? I'm wondering when this fix will be availabble so that I can continue the change to 5.X.X.

@AdrianVerza
Copy link

Hi,
we are also affected by this issue, is there any forecast regarding when this will be rolled out?
Thanks!

@marcingrzejszczak
Copy link
Contributor

@ryanjbaxter it's a pitty this didn't go in the last release

@ryanjbaxter
Copy link
Contributor

Yeah, feel free to ping me in the future. It is hard to monitor everything.

@ryanjbaxter ryanjbaxter merged commit 2c175df into spring-cloud:main Feb 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional provider not found on classpath: org.eclipse.aether.transport.http.HttpTransporterFanewRepositorySystemctory

5 participants