fix: Correct class name of HttpTransporterFactory#2393
fix: Correct class name of HttpTransporterFactory#2393ryanjbaxter merged 3 commits intospring-cloud:mainfrom
Conversation
fixes spring-cloud#2392 Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
|
I wonder how to test this. The only thing that comes to my mind is for now a unit test that would literally check if those strings are FQN of classes taken from the classpath. We have the classes on the classpath already, if we extract the strings into constants we could unit test if those constants are equal to FQN of |
|
This means that spelling mistakes are at least immediately noticeable. I will extract the strings into constants and add tests to check them against the FQN. |
fixes spring-cloud#2392 Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
|
I tried to implement your suggestion of extracting and testing the fqn. Since it was my first commit to a spring project, please let me know if anything is missing. |
fixes spring-cloud#2392 Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
|
Is there anything else I need to do, or is everything okay so far? I'm wondering when this fix will be availabble so that I can continue the change to 5.X.X. |
|
Hi, |
|
@ryanjbaxter it's a pitty this didn't go in the last release |
|
Yeah, feel free to ping me in the future. It is hard to monitor everything. |
fixes #2392